ui: Fix Day Explorer flamegraph root selection for selected tracks - #7187
Open
sanath099 wants to merge 1 commit into
Open
ui: Fix Day Explorer flamegraph root selection for selected tracks#7187sanath099 wants to merge 1 commit into
sanath099 wants to merge 1 commit into
Conversation
Previously, computeDayExplorerFlameGraph traversed recursively upwards through ancestors to top-level roots (`on`, `off`, `[Label] ...`). This caused top-level table roots to always render at Depth 1 in the flamegraph, nesting the user's selected track deep within the hierarchy. This patch removes the `ancestors` and `all_nodes` CTEs and restricts the recursive hierarchy query to `descendants` only. As a result, the selected tracks correctly become the Depth 1 roots of the flamegraph with their subtrees nested underneath. Also changes the descendants recursive step from UNION ALL to UNION to prevent duplicate nodes on overlapping selections. Bug: 482033855
🎨 Perfetto UI Builds
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, computeDayExplorerFlameGraph traversed recursively upwards through ancestors to top-level roots (
on,off,[Label] ...). This caused top-level table roots to always render at Depth 1 in the flamegraph, nesting the user's selected track deep within the hierarchy.This patch removes the
ancestorsandall_nodesCTEs and restricts the recursive hierarchy query todescendantsonly. As a result, the selected tracks correctly become the Depth 1 roots of the flamegraph with their subtrees nested underneath. Also changes the descendants recursive step from UNION ALL to UNION to prevent duplicate nodes on overlapping selections.Bug: 482033855